RDKB-62953: Primary channel ID is incorrect in GUI for OFDM#97
Merged
hpatel006c merged 1 commit intodevelopfrom Jan 29, 2026
Merged
RDKB-62953: Primary channel ID is incorrect in GUI for OFDM#97hpatel006c merged 1 commit intodevelopfrom
hpatel006c merged 1 commit intodevelopfrom
Conversation
Reason for change: Primary channel ID is incorrect in GUI when the locked primary channel is OFDM Test Procedure: Test for Primary channel ID Risks:low Priority: P1 Signed-off-by: pavankumarreddy_balireddy@comcast.com
There was a problem hiding this comment.
Pull request overview
Fixes the GUI’s “Primary channel ID” display when the locked primary downstream channel is OFDM by reordering how OFDM channels are represented in the downstream table.
Changes:
- Builds a DsOfdm channel table and derives lock status from
SubcarrierZeroFreq. - Detects the OFDM primary channel via
ChanIndicatorand moves it to the front of the downstream display list so the “Primary channel” note references the correctChannelID. - Updates the downstream table header
colspanto account for both non-OFDM and OFDM columns.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
hpatel006c
approved these changes
Jan 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason for change: Primary channel ID is incorrect in GUI when the locked primary channel is OFDM
Test Procedure: Test for Primary channel ID
Risks:low
Priority: P1
Signed-off-by: pavankumarreddy_balireddy@comcast.com